stream: preserve error over AbortError in pipeline#62113
Open
marcopiraccini wants to merge 3 commits intonodejs:mainfrom
Open
stream: preserve error over AbortError in pipeline#62113marcopiraccini wants to merge 3 commits intonodejs:mainfrom
marcopiraccini wants to merge 3 commits intonodejs:mainfrom
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62113 +/- ##
==========================================
- Coverage 89.65% 89.63% -0.02%
==========================================
Files 676 676
Lines 206231 206330 +99
Branches 39505 39526 +21
==========================================
+ Hits 184898 184954 +56
- Misses 13463 13485 +22
- Partials 7870 7891 +21
🚀 New features to boost your workflow:
|
ronag
approved these changes
Mar 5, 2026
github-actions
bot
removed
the
request-ci
Collaborator
KhafraDev
reviewed
Mar 5, 2026
| // swallowed by AbortError when the source is an infinite stream. | ||
| async function run() { | ||
| await assert.rejects( | ||
| pipelinep( |
Member
There was a problem hiding this comment.
Suggested change
| pipelinep( | |
| pipeline( |
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
github-actions
bot
removed
the
request-ci
Collaborator
Ethan-Arrowood
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #62089
Errors thrown inside
Readable.map()when used as a pipeline stage with an infinite or fast source stream are swallowed and replaced byAbortError: The operation was aborted.When the map callback throws, the map's internal pump exits its
for awaitloop over the source stream. This triggers the stream's async iterator cleanup, which callsdestroyImpl.destroyer(stream, null). Since the stream isn't finished,destroyercreates a newAbortErrorand destroys the stream with it. ThisAbortErrorpropagates through pipe'seoscallback tofinishImplbefore the original error arrives viapumpToNode, winning the race.finishImplalready allows overwritingERR_STREAM_PREMATURE_CLOSEwith later, more meaningful errors. This change applies the same logic toAbortError, which is also an internal cleanup artifact that should not take precedence over user errors.