Stop minifying CSS on dev.#2540
Merged
Trott merged 1 commit intonodejs:masterfrom Sep 27, 2019
XhmikosR:master-xmr-node-env
Merged
Stop minifying CSS on dev.#2540Trott merged 1 commit intonodejs:masterfrom XhmikosR:master-xmr-node-env
Trott merged 1 commit intonodejs:masterfrom
XhmikosR:master-xmr-node-env
Conversation
Contributor
|
I'm not really sure why I am being assigned to review since I haven't done anything here in years but this seems fine I guess. I've never used |
Contributor
Author
|
cross-env is just a package which makes setting env vars cross platform a breeze, that's all. This change doesn't affect production, only dev. BTW I also tried enabling sourcemaps but I couldn't make it work, so I settled with just not minifying the CSS for now. |
lpinca
approved these changes
Sep 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2538.
#2537 should be adapted to make use of this too along with the other requested changes.