Skip to content

chore(site): add missing .mjs extensions to imports - #9224

Merged
mikeesto merged 1 commit into
nodejs:mainfrom
alexicum:chore/mjs-import-extensions
Oct 20, 2026
Merged

mikeesto merged 1 commit into
nodejs:mainfrom
alexicum:chore/mjs-import-extensions

Conversation

@alexicum

Copy link
Copy Markdown
Contributor

Description

Two files import .mjs modules without the extension.
The rest of the project already uses extensions, including for #site/navigation.mjs and #site/next.constants.mjs.

Check List

  • [x ] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [ x] I have run pnpm format to ensure the code follows the style guide.
  • [ x] I have run pnpm test to check if all tests are passing.
  • [ x] I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@alexicum
alexicum requested a review from a team as a code owner October 17, 2026 10:54
@vercel

vercel Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Oct 17, 2026 10:54am UTC

Request Review

@codecov

codecov Bot commented Oct 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.15%. Comparing base (7c40136) to head (e6f0c5b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9224      +/-   ##
==========================================
+ Coverage   86.13%   86.15%   +0.01%     
==========================================
  Files          86       86              
  Lines        6075     6075              
  Branches      360      360              
==========================================
+ Hits         5233     5234       +1     
+ Misses        838      837       -1     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.20 MB
New Total First Load JS 7.20 MB
Delta 0 B (0.00%)

@mikeesto mikeesto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mikeesto
mikeesto added this pull request to the merge queue Oct 20, 2026
Merged via the queue into nodejs:main with commit 72c1738 Oct 20, 2026
16 checks passed
@alexicum
alexicum deleted the chore/mjs-import-extensions branch October 20, 2026 07:07
@alexicum

Copy link
Copy Markdown
Contributor Author

@mikeesto Thank you!

1 similar comment
@alexicum

Copy link
Copy Markdown
Contributor Author

@mikeesto Thank you!

This branch was successfully deployed

1 active deployment
Preview — e6f0c5b0 Deployed Oct 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants