fix(socks5): destroy sockets after negotiation timeout - #5705
Open
drewmt wants to merge 1 commit into
Open
Conversation
Signed-off-by: drewmt <idrew.mt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Closes #5704.
Rationale
When SOCKS5 authentication or CONNECT negotiation timed out, the connection promise rejected before the socket reached a pool. The open socket was therefore left untracked and could survive for the lifetime of the process.
Changes
Features
N/A
Bug Fixes
Validation:
node --test test/issue-5704.jsnode --test test/socks5-proxy-agent.js test/issue-5704.jsnpm run lintBreaking Changes and Deprecations
N/A
Status