fix(handler): forward onBodySent and onRequestSent in DecoratorHandler and CacheHandler - #5708
Closed
marko1olo wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing — #5696 was merged in the meantime and covers the same fix. Thanks for the quick turnaround upstream! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DecoratorHandler.onBodySentwas declared as a no-op() => {}instead of delegating to the wrapped handler.onRequestSentwas not declared at all, soRequestsilently skipped calling it.Since every built-in interceptor either extends
DecoratorHandler(RedirectHandler,RetryHandler, …) or hand-forwards handler methods (CacheHandler), composing any interceptor onto a dispatcher silently dropped these two hooks for the user's handler.Fixes #5695
Changes
DecoratorHandler.onBodySentnow forwards via optional chaining tothis.#handler.onBodySent?.(...args)DecoratorHandler.onRequestSentadded with the same forwarding patternCacheHandlergainsonBodySentandonRequestSentforwarding (was missing entirely)test/decorator-handler.jscovering delegation and graceful no-op when the inner handler omits the method