Skip to content

Node 26 engine support - #952

Closed
duncanhoggan wants to merge 1 commit into
nodeshift:mainfrom
duncanhoggan:patch-1
Closed

duncanhoggan wants to merge 1 commit into
nodeshift:mainfrom
duncanhoggan:patch-1

Conversation

@duncanhoggan

Copy link
Copy Markdown

The package is currently blocked for node 26, this just expands the engine support

The package is currently blocked for node 26, this just expands the engine support
@lholmquist

Copy link
Copy Markdown
Member

⚠️ Snyk checks are incomplete.

Status Scan Engine Critical High Medium Low Total (0)
⚠️ Open Source Security 0 0 0 0 See details

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@pacostas

Copy link
Copy Markdown
Member

This PR is superseded from this one #953

@hiSandog

Copy link
Copy Markdown

There is a package.json issue in this diff: "node": "^26" || "^24 || ^22 || ^20" is not a valid JSON string value for the engines range. It should probably be a single semver range string such as "^26 || ^24 || ^22 || ^20". It would also be good to add Node 26 to CI before merging so the expanded engine claim is verified.

@pacostas

Copy link
Copy Markdown
Member

@hiSandog the node 26 has been added from this PR #953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants