Skip to content

Adding CSS classes to trigger element when popup is opened/closed#78

Open
stevenmyhre wants to merge 1 commit into
nohros:masterfrom
stevenmyhre:master
Open

Adding CSS classes to trigger element when popup is opened/closed#78
stevenmyhre wants to merge 1 commit into
nohros:masterfrom
stevenmyhre:master

Conversation

@stevenmyhre
Copy link
Copy Markdown

No description provided.

@graffic
Copy link
Copy Markdown
Contributor

graffic commented Apr 2, 2015

I'd say it is better if the scope has isOpen so you can use ng-class later and use whatever classes you want.

IMHO Hard coded classes don't mix well with different code bases.

@stevenmyhre
Copy link
Copy Markdown
Author

That is a good point @graffic, but the directive currently doesn't have an isolate scope, so it would potentially override other isOpen scope variables due to prototypical scope inheritance, causing a similar issue. The CSS class was a quick and easy way to solve my problem, though I'm open to other options if they are viable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants