Skip to content

Add ?limit= parameter#42

Draft
nomeata wants to merge 1 commit intomasterfrom
limit-param
Draft

Add ?limit= parameter#42
nomeata wants to merge 1 commit intomasterfrom
limit-param

Conversation

@nomeata
Copy link
Copy Markdown
Owner

@nomeata nomeata commented Jun 30, 2025

This fixes #40.

@nomeata
Copy link
Copy Markdown
Owner Author

nomeata commented Jun 30, 2025

This would fix #40, but only in a rather superficial way: The hits are still generated, just not returned to the client. I wonder how useful that is.

I’d suggest we don’t merge this yet, but wait until I had time to refactor the code to pass the parameter through to the backend (or merge backend and frontend). Until then, @oOo0oOo, I suggest that your client passes the limit attribute (it will be ignored for now), but also applies the limit client side. How does that sound?

@oOo0oOo
Copy link
Copy Markdown
Contributor

oOo0oOo commented Jun 30, 2025

Absolutely, I would welcome a proper implementation. There is no urgency on my end, I'll make my changes when this is released.

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Mar 9, 2026

Let me just say that I would also like to have this. (To un-#xy, I'd like to audit all definitions which take a certain type as explicit argument. Loogle doesn't allow such fine-grained search at the moment. There are 300-400 definitions mentioning the type, so auditing them all is fine --- but at the moment made impossible through this limit.)

@nomeata
Copy link
Copy Markdown
Owner Author

nomeata commented Mar 9, 2026

So your use case is extending the limit, not efficiently reducing it, right?

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Mar 9, 2026

Yes - I'd like an opt-in mechanism to look at all results.

@nomeata
Copy link
Copy Markdown
Owner Author

nomeata commented Mar 9, 2026

I feel like that's not a good idea on the public service. But maybe on local use it could be fine?

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Mar 9, 2026

Right, I can run loogle locally, and it's even in the README. So, being able to lift the limit should do for my purposes, indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit the number of results returned via the /json endpoint.

3 participants