Parse one file at a time to allow templates to overwrite blocks#291
Open
Makeshift wants to merge 4 commits into
Open
Parse one file at a time to allow templates to overwrite blocks#291Makeshift wants to merge 4 commits into
Makeshift wants to merge 4 commits into
Conversation
Author
|
Unfortunately, tests fail and I don't know enough golang to fix them :( |
Owner
|
Seems reasonable but you need to resolve your merge conflicts and also it doesn't seem like it works? I still see the content that should be overwritten in the README generated in your example chart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the compilation errors in #276 and allows
defineto correctly overrideblockwhen encountered in a later template. It also stops it from defaulting to the default template if one template file isn't found, which I think was a bug introduced by #276.I also added an example of the functionality.
By extension, this also fixes #277.
For anyone that wants to risk using this branch, you can download the binaries from here and images here.