build(release): update the pre-commit config and hook version with tag release#312
Open
umarhussain15 wants to merge 2 commits into
Open
build(release): update the pre-commit config and hook version with tag release#312umarhussain15 wants to merge 2 commits into
umarhussain15 wants to merge 2 commits into
Conversation
release This change will also ensure that helm-docs-container hook has the published docker image tag instead of latest.
norwoodj
reviewed
Mar 6, 2026
| echo "Release version must be of the form 'v1.2.3'" | ||
| exit 1 | ||
| fi | ||
| go install github.com/mikefarah/yq/v4@latest # Install yq via go |
Owner
There was a problem hiding this comment.
Can you instead add this as an instruction to the README to install this before performing a release? Then remove this, I don't want to try to install this everytime I do a release.
Otherwise looks good!
Author
There was a problem hiding this comment.
We can add a command -v yq in the script and let user know if it's missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the issue: #222
build(release): update the pre-commit config and hook version with tag release
This change will also ensure that helm-docs-container hook has the published docker image tag instead of latest.
Workflow:
scripts/release <version>to prepare the commit with the release tagExample diff after running the
scripts/release <version>: