Relax version requirements on glam - #1070
Open
decorator-factory wants to merge 1 commit into
Open
decorator-factory wants to merge 1 commit into
decorator-factory wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the
glamversion bound to0.27.x(which is over 2 years old) leads to problems when using other game-adjacent libraries, like Parry.I think it's a good idea to just have a lower bound on the version. If there's an incompatibility in a later
glamversion, it's easy to fix by pinning down the version in an application'sCargo.toml(e.g.glam = 0.32.0), without needing to forkmacroquad.I ran
cargo teston 0.28, 0.29, 0.30, 0.31, 0.32, and 0.33 and no new test failures appear (the old ones from #693 are still there).