Require explicit resource IDs for targeted commands - #66
Closed
leo-notte wants to merge 1 commit into
Closed
Conversation
|
| Filename | Overview |
|---|---|
| internal/cmd/sessions.go | Removes implicit session resolution and persistence, marks every session-targeting command's ID flag required, and fetches viewer URLs for the explicitly selected session. |
| internal/cmd/functions.go | Removes implicit function resolution and persistence while consistently requiring function IDs on targeted commands. |
| internal/cmd/page.go | Makes the inherited session ID flag required for all page actions and updates command examples. |
| internal/cmd/files.go | Enforces explicit session IDs only for session-backed list and download operations while preserving uploads behavior. |
| internal/cmd/clear.go | Consolidates cleanup of all five historical resource-pointer files without changing the prior fail-fast error semantics. |
| internal/config/config.go | Removes constants for resource ID environment variables and persisted current-resource files that production commands no longer use. |
| README.md | Updates session, page, function, and file workflows to capture and pass resource IDs explicitly. |
| tests/integration/functions_test.go | Replaces implicit function-ID integration coverage with explicit missing-flag behavior coverage. |
| tests/integration/page_commands_test.go | Adds integration coverage verifying page commands reject a missing session ID. |
Reviews (1): Last reviewed commit: "Require explicit resource IDs" | Re-trigger Greptile
Contributor
Author
|
Closing because the intended scope is the agent skills and examples only; the CLI should retain its current inferred-resource behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing