fix(s3): drop {env, _} tag from access_key/secret_key#2
Merged
Conversation
access_key and secret_key now accept the env-var name as a string directly,
matching idiomatic Erlang config patterns. The tagged-tuple form was an
uncommon shape that added a small DSL with no benefit over passing the
name directly.
Before:
access_key => {env, "S3_ACCESS_KEY"}
After:
access_key => "S3_ACCESS_KEY"
ℹ️ 15 OTP CVEs auto-ignored (already fixed in running version)These CVEs are patched in the installed OTP version but NVD data
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The S3 adapter's
access_keyandsecret_keyaccepted a tagged tuple{env, "VAR"}to look up credentials from the OS environment. Tagged-tuple config keys are uncommon in Erlang and added a small DSL with no benefit over passing the env-var name directly.Change
The adapter resolves the name to its env-var value at store-init time. Same lazy-lookup semantics, simpler config shape.
Breaking?
Technically yes for anyone on v0.1.0, but the lib is hours old with no consumers. Tagging v0.1.1 after merge.
Test plan
rebar3 compilecleanrebar3 ct— 16/16 passrebar3 dialyzercleanrebar3 xrefcleanrebar3 fmt --checkclean