chore: validate package existence before adding to compare#1218
chore: validate package existence before adding to compare#1218iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
Conversation
iiio2
commented
Feb 8, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request adds asynchronous package existence validation to the PackageSelector component. When users press Enter to add a package, the component now calls checkPackageExists to verify the package name before adding it. The component introduces isCheckingPackage and packageError state variables, disables the input during validation, displays a spinner icon whilst checking, and shows error messages for non-existent packages. The associated test file is updated to mock the validation function and verify that only existing packages are added, whilst non-existent ones trigger error alerts. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
|
🤔 @iiio2 could you explain what problem this is solving? I tried poking around in the app and I couldn't find a scenario this would change. |
|
@serhalp , I thought I can provide validation when no package found. |