Skip to content

Enhance FAB interactions and padding adjustments #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hiirbaf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhance FAB interactions and padding adjustments #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaDetailsController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,11 @@ class MangaDetailsController :

if (isTablet) return

when {
dy > 0 && binding.fab.isExtended -> binding.fab.shrink()
dy < 0 && !binding.fab.isExtended -> binding.fab.extend()
}

val headerBinding = getHeader()?.binding
if (headerBinding == null) {
if (binding.fab.isEnabled) {
Expand Down Expand Up @@ -569,7 +574,8 @@ class MangaDetailsController :

private fun setInsets(insets: WindowInsetsCompat, appbarHeight: Int, offset: Int) {
val systemInsets = insets.ignoredSystemInsets
binding.recycler.updatePaddingRelative(bottom = systemInsets.bottom)
val fabPadding = 72.dpToPx // FAB height (56dp) + margin (16dp)
binding.recycler.updatePaddingRelative(bottom = systemInsets.bottom + fabPadding)
binding.tabletRecycler.updatePaddingRelative(bottom = systemInsets.bottom)
val tHeight = toolbarHeight.takeIf { it ?: 0 > 0 } ?: appbarHeight
headerHeight = tHeight + systemInsets.top
Expand Down
Loading