feat!: replace string error reasons with typed error selectors#22
Open
mfw78 wants to merge 1 commit into
Open
Conversation
Reason payloads become bytes4 selectors of handler-declared custom errors instead of free strings. Declared errors are part of the handler ABI, so any ABI-aware consumer resolves a reasonCode to a name without a bespoke table, revert data shrinks, and reason constants become type-checked declarations. BREAKING CHANGE: OrderNotValid, PollTryNextBlock, PollTryAtTimestamp and PollTryAtBlock now carry bytes4 reasonCode instead of string.
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason payloads become
bytes4selectors of handler-declared custom errors instead of free strings:OrderNotValid,PollTryNextBlock,PollTryAtTimestamp,PollTryAtBlockcarrybytes4 reasonCodeStrikeNotReached(),BeforeTwapStart(), ...) — part of the handler ABI, so consumers resolve codes to names without a bespoke tableBREAKING: error signatures change.
Part of #1.