feat!: compose fill state into the registry poll path#24
Open
mfw78 wants to merge 1 commit into
Open
Conversation
Reshape getTradeableOrderWithSignature around the structured generator verdict and an orthogonal, registry-observed fill overlay: - PollResult composes the handler GeneratorResult with a FillStatus (NONE / PARTIALLY_FILLED / FILLED / INVALIDATED) derived from GPv2Settlement.filledAmount; invalidateOrder is reported as INVALIDATED, not FILLED - a partially filled partiallyFillable order keeps returning its signature, so the remainder is no longer stranded - checkOrder returns the same composed PollResult and now applies the ERC-165 handler gate via the shared _poll helper - create/setRoot write the cabinet before emitting and carry the resolved cabinet value in a new bytes context event field - emit ConditionalOrderRemoved on order removal - state mappings use named parameters BREAKING CHANGE: getTradeableOrderWithSignature returns (PollResult, bytes); ConditionalOrderCreated and MerkleRootSet gain a bytes context parameter (topic0 changes).
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reshape
getTradeableOrderWithSignaturearound the generator verdict plus an orthogonal, registry-observed fill overlay:PollResultcomposes the handlerGeneratorResultwith aFillStatus(NONE / PARTIALLY_FILLED / FILLED / INVALIDATED) derived fromGPv2Settlement.filledAmount;invalidateOrderreports as INVALIDATED, not FILLED (closes polling: overlay mislabels invalidateOrder'd orders as FILLED #11)partiallyFillableorder keeps returning its signature, so the remainder is no longer stranded (closes settlement: fill overlay strands the remainder of a partiallyFillable order #10)checkOrderreturns the same composedPollResultand applies the ERC-165 handler gate via the shared_pollhelper (closes polling: checkOrder reports SUCCESS on a filled order (skips the fill overlay) #9, closes composable-cow: checkOrder skips the supportsInterface guard #6)create/setRootwrite the cabinet before emitting and carry the resolved value in a newbytes contextevent field (closes composable-cow: emit cabinet context in create/setRoot events and write before emit #14)ConditionalOrderRemovedemitted on removalTogether with the generator half this delivers the verdict/fill split (closes #16).
BREAKING:
getTradeableOrderWithSignaturereturns(PollResult, bytes);ConditionalOrderCreatedandMerkleRootSetgain abytes contextparameter (topic0 changes).Part of #1.