fix: reject degenerate zero-amount orders at handler validation#26
Open
mfw78 wants to merge 1 commit into
Open
fix: reject degenerate zero-amount orders at handler validation#26mfw78 wants to merge 1 commit into
mfw78 wants to merge 1 commit into
Conversation
A fill-or-kill order with sellAmount == 0 settles without ever incrementing filledAmount, so the native replay guard never trips and the order is indefinitely replayable. Reject zero amounts at handler validation so such an order is never generated, and bound the TWAP simulation fuzz so the suite runs green within test memory limits.
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fill-or-kill order with a zero amount settles without ever incrementing
filledAmount, so the native replay guard never trips and the order is indefinitely replayable. Reject zero amounts at handler validation (closes #12), enforce the TWAP parameter gate on every entry path (closes #4), and bound the simulation fuzz so the suite runs green within test memory limits.Part of #1.