feat: add IOrderManifest interface with base defaults#27
Open
mfw78 wants to merge 1 commit into
Open
Conversation
Sidecar interface (own ERC-165 id, feature-detected) that lets analytics, UIs and indexers enumerate the discrete orders a conditional order will produce: - Cardinality names the totalOrders semantics directly: EXACT / CAPPED / UNBOUNDED - the pagination contract is explicit: an empty page with hasMore=true is unreachable, so a naive offset walker always terminates; UNBOUNDED handlers expose index 0 only - getManifestPage carries a status string so a not-yet-active order (WAIT) is distinguishable from a permanently invalid one on an empty page BaseConditionalOrder defaults to a single-shot manifest (EXACT, 1) wrapping generateOrder.
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidecar interface (own ERC-165 id, feature-detected, never on the settlement path) for enumerating the discrete orders a conditional order will produce:
Cardinalitynames thetotalOrderssemantics directly: EXACT / CAPPED / UNBOUNDED (closes manifest: rename Cardinality to EXACT/CAPPED/UNBOUNDED #13)hasMore == trueis unreachable, so a naive offset walker always terminatesgetManifestPagecarries abytes4 reasonCodeso a not-yet-active order is distinguishable from a permanently invalid one on an empty page (closes manifest: default getManifestPage hides the WAIT reason as an empty page #5)BaseConditionalOrderdefaults to a single-shot manifest (EXACT, 1)Part of #1.