venue-test: version fixture files and reject empty vector sets#437
Open
mfw78 wants to merge 3 commits into
Open
venue-test: version fixture files and reject empty vector sets#437mfw78 wants to merge 3 commits into
mfw78 wants to merge 3 commits into
Conversation
Fixture files lead with a format version; a reader fails closed on an unknown tag and refuses an empty vector or golden set, which would conform vacuously. Published reference fixtures regenerated.
lgahdl
approved these changes
Jul 17, 2026
lgahdl
left a comment
lgahdl
left a comment
Collaborator
There was a problem hiding this comment.
Verified the two risks that matter here and both check out clean: FormatVersion fails closed identically for codec vectors and header goldens (both route through the same shared fixture::FormatVersion::deserialize, no asymmetry), and the empty-set rejection is genuinely enforced at both parse-time (fixture::non_empty) and check-time (the is_empty() guard in each check()) as two independent gates, not just one dressed up as two. The fixture JSON files got "version": 1" spliced correctly into existing content, and the echo-venue change is test-only. Comments accurately describe the new fail-closed/never-empty invariants. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a
FormatVersiondiscriminator to codec-vector and header-golden fixture files (parse fails closed on an unknown version); reject empty vector/golden sets on parse and on the conformance check.Why
Cross-language codec/header goldens conform vacuously when empty and carried no tag to catch a stale reader against a future file layout. The migration-cruft deletion and the
denied()MUST-NOT-retry doc from the same fold-tail scope are already in tree.Testing
cargo test -p nexum-venue-test(unit + conformance + doctests, all green).AI Assistance
Implemented and tested with Claude Code.
Closes #365