Update pyproject #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we should try to handle l10n in its own repo |
seanbudd
reviewed
Dec 16, 2025
Comment on lines
+24
to
+32
| "crowdin-api-client==1.21.0", | ||
| "lxml>=6.0.2", | ||
| "markdown>=3.10", | ||
| "markdown-link-attr-modifier==0.2.1", | ||
| "mdx-gh-links==0.4", | ||
| "mdx-truly-sane-lists==1.3", | ||
| "nh3==0.2.19", | ||
| "requests>=2.32.5", | ||
| "scons==4.10.1", |
Member
There was a problem hiding this comment.
are all of these required for the current state? or are some only necessary with #1 ?
Member
There was a problem hiding this comment.
can you separate the ones only required for the submodule and #1, to those PRs
seanbudd
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
### Description
This PR updates Pyproject.
@seanbudd, I advice to pay speciall attention to Pyright. Should we exclude _l10n?
I'm not sure about running Pyright locally on my computer...