Skip to content
This repository was archived by the owner on Dec 7, 2019. It is now read-only.

Clarify required dependencies for Store-Kotlin in README.#376

Closed
ychescale9 wants to merge 1 commit intonytimes:feature/rx2from
ychescale9:patch-1
Closed

Clarify required dependencies for Store-Kotlin in README.#376
ychescale9 wants to merge 1 commit intonytimes:feature/rx2from
ychescale9:patch-1

Conversation

@ychescale9
Copy link
Contributor

Prior to AGP 3.3.x, only declaring the implementation 'com.nytimes.android:store-kotlin3:CurrentVersion' is enough as the required store classes in the core store module are also brought in.

Since AGP 3.3.x this no longer works as classes in the com.nytimes.android:store3 artifact can't be resolved unless adding implementation 'com.nytimes.android:store3:CurrentVersion' alongside the Kotlin dependency.

PR adds implementation 'com.nytimes.android:store3:CurrentVersion' in README.md for Store-Kotlin

Question: was com.nytimes.android:store-kotlin3:CurrentVersion intended to also bring in the com.nytimes.android:store3 dependency for the consuming module? If that's the case should we change apiElements project(':store') to api project(':store') in store-kotlin/build.gradle?

@digitalbuddha
Copy link
Contributor

I don't see how it can be used without store, if you don't mind make the change in gradle.

@ychescale9
Copy link
Contributor Author

We are making the gradle change instead: #380

@ychescale9 ychescale9 closed this Feb 22, 2019
@ychescale9 ychescale9 deleted the patch-1 branch February 22, 2019 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants