This repository was archived by the owner on Dec 7, 2019. It is now read-only.
Clarify required dependencies for Store-Kotlin in README.#376
Closed
ychescale9 wants to merge 1 commit intonytimes:feature/rx2from
ychescale9:patch-1
Closed
Clarify required dependencies for Store-Kotlin in README.#376ychescale9 wants to merge 1 commit intonytimes:feature/rx2from ychescale9:patch-1
ychescale9 wants to merge 1 commit intonytimes:feature/rx2from
ychescale9:patch-1
Conversation
Contributor
|
I don't see how it can be used without store, if you don't mind make the change in gradle. |
Contributor
Author
|
We are making the gradle change instead: #380 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to AGP 3.3.x, only declaring the
implementation 'com.nytimes.android:store-kotlin3:CurrentVersion'is enough as the required store classes in the corestoremodule are also brought in.Since AGP 3.3.x this no longer works as classes in the
com.nytimes.android:store3artifact can't be resolved unless addingimplementation 'com.nytimes.android:store3:CurrentVersion'alongside the Kotlin dependency.PR adds
implementation 'com.nytimes.android:store3:CurrentVersion'in README.md for Store-KotlinQuestion: was
com.nytimes.android:store-kotlin3:CurrentVersionintended to also bring in thecom.nytimes.android:store3dependency for the consuming module? If that's the case should we changeapiElements project(':store')toapi project(':store')instore-kotlin/build.gradle?