Don't let an empty submissions cell make get_course_users return None#70
Open
cyrus- wants to merge 1 commit into
Open
Don't let an empty submissions cell make get_course_users return None#70cyrus- wants to merge 1 commit into
cyrus- wants to merge 1 commit into
Conversation
get_course_members assumes the "# submissions" column is 3rd-from-last (num_submissions_column = max(len(headers) - 3, 3)). On rosters with extra trailing action columns that index lands on an empty cell, so int(cells[...].text) raises ValueError — which get_course_users() catches and turns into a None return, i.e. the entire roster silently fails to load. Guard the int() parse (default to 0 on ValueError/IndexError) so the roster — names, emails, roles, ids — still loads. Adds credential-free unit tests for the empty-cell and numeric-cell cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_course_members assumes the "# submissions" column is 3rd-from-last (num_submissions_column = max(len(headers) - 3, 3)). On rosters with extra trailing action columns that index lands on an empty cell, so int(cells[...].text) raises ValueError — which get_course_users() catches and turns into a None return, i.e. the entire roster silently fails to load.
Guard the int() parse (default to 0 on ValueError/IndexError) so the roster — names, emails, roles, ids — still loads. Adds credential-free unit tests for the empty-cell and numeric-cell cases.