Fix overflow behaviour on small screens for <OakInlineBanner/> - #765
Open
orangemug wants to merge 1 commit into
Open
Fix overflow behaviour on small screens for <OakInlineBanner/>#765orangemug wants to merge 1 commit into
<OakInlineBanner/>#765orangemug wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
orangemug
marked this pull request as ready for review
August 19, 2026 11:50
|
Contributor
|
How do I reproduce the original issue in Storybook? 😅 I might be doing a silly, but I am looking at the stories in inspector on mobile, and then adding loads of text to title/message/cta, but I cant see the original issue where it overflows. Im looking at current main and the preview deploy, but seem to behave the same? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to review this PR
Leave this text block for the reviewer
Add your PR description below
Fix overflow behaviour on small screens for
<OakInlineBanner/>raised in https://app.notion.com/p/oaknationalacademy/Inline-banner-on-mobile-3b926cc4e1b180f49f49d1d357101880?source=copy_linkLink to the design doc
https://www.figma.com/design/YcWQMMhHPVVmc47cHHEEAl/Oak-Design-Kit?node-id=9923-4249&m=dev
A link to the component in the deployment preview
<OakInlineBanner/><OakDownloadsJourneyChildSubjectTierSelector/>— uses<OakInlineBanner/><OakTeacherNotesModal/>— uses<OakInlineBanner/>Testing instructions
Regression test
<OakInlineBanner/>