Skip to content

Fix overflow behaviour on small screens for <OakInlineBanner/> - #765

Merged
orangemug merged 3 commits into
mainfrom
fix/OC-34-inline-banner-fixes
Aug 26, 2026
Merged

Fix overflow behaviour on small screens for <OakInlineBanner/>#765
orangemug merged 3 commits into
mainfrom
fix/OC-34-inline-banner-fixes

Conversation

@orangemug

@orangemug orangemug commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Fix overflow behaviour on small screens for <OakInlineBanner/> raised in https://app.notion.com/p/oaknationalacademy/Inline-banner-on-mobile-3b926cc4e1b180f49f49d1d357101880?source=copy_link

Link to the design doc

https://www.figma.com/design/YcWQMMhHPVVmc47cHHEEAl/Oak-Design-Kit?node-id=9923-4249&m=dev

A link to the component in the deployment preview

Testing instructions

Regression test <OakInlineBanner/>

@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
oak-components-storybook Ready Ready Preview Aug 26, 2026 9:21am

Request Review

@orangemug
orangemug marked this pull request as ready for review August 19, 2026 11:50
@orangemug
orangemug requested review from charsville and left23 August 19, 2026 11:50
@charsville

Copy link
Copy Markdown
Contributor

How do I reproduce the original issue in Storybook? 😅

I might be doing a silly, but I am looking at the stories in inspector on mobile, and then adding loads of text to title/message/cta, but I cant see the original issue where it overflows.

Im looking at current main and the preview deploy, but seem to behave the same?

@notion-workspace

Copy link
Copy Markdown

Inline banner on mobile

@sonarqubecloud

Copy link
Copy Markdown

@rightsaidjames rightsaidjames left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On banners without a title prop, the message and CTA were split into two columns. Now, on viewport widths below 750px, the link text wraps onto a separate line, avoiding the previous squashing behaviour. LGTM!

Screenshot 2026-08-26 at 10 28 12 Image

@orangemug
orangemug merged commit a393d95 into main Aug 26, 2026
10 checks passed
@orangemug
orangemug deleted the fix/OC-34-inline-banner-fixes branch August 26, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants