Added <OakErrorBoundary/> component - #764
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
orangemug
force-pushed
the
feat/OC-32-error-boundary
branch
from
August 19, 2026 10:34
736f3c3 to
b042c1b
Compare
orangemug
marked this pull request as ready for review
August 19, 2026 10:35
messmike
approved these changes
Aug 19, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to review this PR
Leave this text block for the reviewer
Add your PR description below
Added a new
<OakErrorBoundary/>component, to allow us to catch error and not crash the pageLink to the design doc
https://www.figma.com/design/YcWQMMhHPVVmc47cHHEEAl/Oak-Design-Kit?node-id=23664-3905&m=dev
A link to the component in the deployment preview
https://oak-components-storybook-git-feat-oc-32-error-boundary.vercel.thenational.academy/?path=/docs/components-messaging-and-feedback-oakerrorboundary--docs
Testing instructions
Trigger the errors in storybook and check the correct thing happens. Also check designs against figma