slack: pace chat.postMessage to <=1/sec per channel#330
Closed
nazriz wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds per-channel pacing for Slack chat.postMessage calls to reduce Slack 429s during alert bursts.
Changes:
- Introduces per-channel pacing state (
post_pacing) on theSlackclient. - Adds slot-reservation logic (
reserve_slot) plus unit tests for pacing behavior. - Gates
post_messagewith an async wait to enforce ≤ 1 message/sec/channel.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| runtime/plaid/src/apis/slack/mod.rs | Adds per-channel pacing state to the Slack client via a mutex-protected map. |
| runtime/plaid/src/apis/slack/api.rs | Implements pacing logic + tests; applies pacing before chat.postMessage calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Closed in favour of: #332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During alert bursts the notifier fires many chat.postMessage calls to the same channel
at once. Slack allows ~1/sec/channel, so the excess returns HTTP 429 and those alerts
are dropped.
To solve for this: Pace chat.postMessage per channel inside the Slack API: before posting, wait until the
channel's next 1s slot, then reserve the following one. Same-channel posts end up ~1s
apart; different channels are independent (the pacing lock is released before the wait).