Skip to content

Make dependency check always run and add workflow concurrency grouping#345

Merged
obelisk merged 6 commits into
mainfrom
thanh/update-dependency-check
Jul 20, 2026
Merged

Make dependency check always run and add workflow concurrency grouping#345
obelisk merged 6 commits into
mainfrom
thanh/update-dependency-check

Conversation

@timweri

@timweri timweri commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Problem 1: The dependency check CI blocks PRs when the relevant files are not modified

Instead of skipping dependency check trigger when relevant files are not affected, we always run the workflow, but decide to skip within the workflow logic.

Problem 2: When you push a new commit to a PR, CI runs for previous commits still run, wasting resources

Add concurrency grouping for PR-based workflow runs. For branch pushes, the group ID falls back to run_id so it doesn't affect branch pushes.

Copilot AI review requested due to automatic review settings July 20, 2026 22:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “Dependency Minimum Age Check” GitHub Actions workflow to run on every pull request event, while conditionally running the heavier dependency-check steps only when relevant files change.

Changes:

  • Removed on.pull_request.paths so the workflow triggers for all PRs.
  • Added a dorny/paths-filter step and gated Rust/tooling steps behind if: steps.filter.outputs.relevant == 'true'.
  • Updated pinned action SHAs (e.g., actions/checkout, cargo-oxidate).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/DependencyCheck.yaml
Copilot AI review requested due to automatic review settings July 20, 2026 22:58
@timweri
timweri marked this pull request as ready for review July 20, 2026 23:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/DependencyCheck.yaml Outdated
Copilot AI review requested due to automatic review settings July 20, 2026 23:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.github/workflows/DependencyCheck.yaml:24

  • actions/checkout runs even when no relevant files changed. Since the workflow is now triggered for all PRs, this will still download the repo on every PR even though all subsequent work is skipped. You can avoid the extra runtime/cost by gating the checkout step with the same paths-filter condition.
      - name: Checkout repository
        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

Copilot AI review requested due to automatic review settings July 20, 2026 23:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/DependencyCheck.yaml:26

  • actions/checkout runs even when the change set is not relevant, so the workflow still checks out the repo on every PR even though later steps are skipped. Also, the repo’s other workflows consistently use actions/checkout@v4 (e.g. .github/workflows/Integration.yml:78, FeatureCheck.yml:40), so using a pinned SHA for v7.0.1 here is inconsistent and may introduce different behavior than the rest of CI.
      - name: Checkout repository
        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

Comment thread .github/workflows/FeatureCheck.yml
Copilot AI review requested due to automatic review settings July 20, 2026 23:15
@timweri timweri changed the title Make dependency check always run Make dependency check always run and add workflow concurrency grouping Jul 20, 2026
obelisk
obelisk previously approved these changes Jul 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

.github/workflows/DependencyCheck.yaml:25

  • When there are no relevant changes, the workflow correctly skips Rust install and cargo-oxidate, but it still performs a full checkout. Add the same if: guard to the checkout step to avoid unnecessary work on unrelated PRs.
      - name: Checkout repository
        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

Comment thread .github/workflows/LocalDevCheck.yml
Comment thread .github/workflows/Integration.yml
Comment thread .github/workflows/FeatureCheck.yml
Comment thread .github/workflows/DynamoDBForRules.yml
Comment thread .github/workflows/DockerChecks.yml
Comment thread .github/workflows/DependencyCheck.yaml
Copilot AI review requested due to automatic review settings July 20, 2026 23:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

.github/workflows/DockerChecks.yml:11

  • concurrency.group here is inconsistent with the other workflows updated in this PR (it omits github.event_name). That makes it easier to accidentally introduce cross-event cancellations later (e.g., if another trigger is added), and it diverges from the PR’s stated grouping format.
concurrency:
  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
  cancel-in-progress: true

.github/workflows/DependencyCheck.yaml:30

  • When steps.filter.outputs.relevant is false, the workflow still checks out the repository even though no subsequent steps will run. Since dorny/paths-filter uses the GitHub REST API for pull_request events, you can skip checkout to make irrelevant runs complete faster.
      - name: Checkout repository
        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

Comment thread .github/workflows/DependencyCheck.yaml
@timweri
timweri requested a review from obelisk July 20, 2026 23:27
@obelisk
obelisk merged commit 593065b into main Jul 20, 2026
24 checks passed
@timweri
timweri deleted the thanh/update-dependency-check branch July 20, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants