chore: remove Bifrost LLM dispatch#7233
Open
calvinmclean wants to merge 2 commits into
Open
Conversation
calvinmclean
force-pushed
the
chore/remove-bifrost-dispatch
branch
from
July 22, 2026 14:36
1291221 to
95a91b5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy Bifrost-based LLM proxy dispatch path and associated types, moving the system toward explicit, named LLM proxy routes and dialect handling.
Changes:
- Removed Bifrost request/streaming support from message policy evaluation and simplified dialect dispatch logic.
- Removed the gateway’s generic
/api/llm-proxy/{path...}dispatch handler and theLLMProxyActivitymodel/migration entries. - Updated token-usage tracking and tests to drop the Bifrost dialect and align with named proxy routes (e.g., generic-responses).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/messagepolicy/evaluate.go | Removes Bifrost request types and Bifrost call path; tightens dialect dispatch via a switch. |
| pkg/gateway/types/activity.go | Removes LLMProxyActivity type. |
| pkg/gateway/server/router.go | Removes the generic /api/llm-proxy/{path...} route handler registration. |
| pkg/gateway/server/llmproxy.go | Removes dispatchLLMProxy and its request-body helper. |
| pkg/gateway/server/llmproxy_usage.go | Drops Bifrost dialect handling in token usage tracker selection. |
| pkg/gateway/server/llmproxy_test.go | Updates/cleans up proxy path tests to remove dispatch/bifrost cases. |
| pkg/gateway/db/db.go | Removes LLMProxyActivity from AutoMigrate set. |
| pkg/controller/handlers/nanobotagent/nanobotagent.go | Updates provider base URL derivation to use named routes (but currently leaves a broken fallback). |
| pkg/controller/handlers/nanobotagent/nanobotagent_test.go | Updates tests for named-route behavior and fallbacks (but currently expects a now-removed dispatch base URL for unknown providers). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
calvinmclean
marked this pull request as ready for review
July 24, 2026 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: obot-platform/nanobot#352