fix: reject duplicate skill sources#7295
Draft
calvinmclean wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #7272 by enforcing uniqueness for Skill Sources (Skill Repositories) on both the backend API and UI, preventing duplicate display names and duplicate repository URLs and surfacing clearer validation errors in the admin Skills page.
Changes:
- Add server-side validation to reject creating/updating a Skill Source when another source already uses the same
displayNameor normalizedrepoURL(409 Conflict). - Improve admin UI error display by parsing API error payloads/messages into a user-facing message.
- Add handler tests covering duplicate-name and duplicate-URL rejection, and ensuring updates can keep their own name/URL.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/user/src/routes/admin/skills/+page.svelte | Uses parseErrorContent() so validation/conflict errors are shown as clean user-facing messages. |
| pkg/api/handlers/skills_test.go | Adds coverage for duplicate Skill Source name/URL rejection on create/update, and allows self-update. |
| pkg/api/handlers/skillrepositories.go | Adds validateUniqueSkillRepository and wires it into create/update flows to enforce uniqueness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #7272