Repository navigation
fix(config): apply defaults to generators-list entries (PIPE-1493) - #316
Open
Dylan-M wants to merge 1 commit into
Conversation
Dylan-M
force-pushed
the
dylanmyers/pipe-1446-support-multiple-simultaneous-outputs-fan-out
branch
from
September 22, 2026 22:04
8495fa9 to
1efedbd
Compare
…erator+generators Assisted-By: Claude Opus 4.8
Dylan-M
force-pushed
the
dylanmyers/pipe-1493-apply-defaults-to-generators-list-entries
branch
from
September 22, 2026 22:04
5f4444d to
e8839a9
Compare
eKuG
requested changes
Sep 28, 2026
Comment on lines
+88
to
+92
| merged := make([]Generator, len(c.Generators)) | ||
| for i, g := range c.Generators { | ||
| m := g | ||
| fillZeroFields(reflect.ValueOf(&m).Elem(), reflect.ValueOf(c.Generator)) | ||
| merged[i] = m |
There was a problem hiding this comment.
This has the same zero-fill problem, now for generators:. An explicit wel.manageEventSources: false becomes true, so blitz registers and deregisters event sources (which needs admin) after the user opted out. filegen.cache-enabled: false also becomes true.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Entries in the
generators:list did not receive the defaults the singulargenerator:gets. An entry that omitted a field likeworkersran with a zero value and produced nothing.EffectiveGeneratorsnow overlays each list entry onto the defaulted singularGenerator, filling unset fields while entry-set fields win.A config that sets both
generatorandgeneratorsis now rejected at load, since the two together are ambiguous.Checklist