Repository navigation
Conversation
Assisted-By: Claude Opus 4.8
eKuG
requested changes
Sep 28, 2026
| NewOverride("generator.count", "total number of logs to generate (0 = unlimited)", 0), | ||
| NewOverride("onFinish", "behavior when finite generation completes. One of: exit|idle", "exit"), | ||
| NewOverride("generator.type", "generator type. One of: nop|json|winevt|wel|palo-alto|apache-common|apache-combined|apache-error|nginx|postgres|kubernetes|filegen|okta|hostmetrics|traces", GeneratorTypeNop), | ||
| NewOverride("generator.type", "generator type. One of: nop|json|winevt|wel|palo-alto|apache-common|apache-combined|apache-error|nginx|postgres|kubernetes|filegen|okta|hostmetrics|traces|fix|f5", GeneratorTypeNop), |
There was a problem hiding this comment.
There are no generator.f5.* overrides, so the BLITZ_GENERATOR_F5_* env vars and CLI flags are never bound. The blitz-f5 compose service fails with f5 generator workers must be 1 or greater, got 0, and --generator-f5-workers gives unknown flag. Only YAML works. Also, an unset seed comes through as 0, not DefaultConfig's -1, so every run produces the same records.
| // buildLine picks a weighted product and builds one log line from it. | ||
| func (g *Generator) buildLine(r *rand.Rand) string { | ||
| p := g.pickProduct(r) | ||
| return p.Build(r, &catalog.Ctx{Now: time.Now(), Hostname: g.cfg.Hostname}) |
There was a problem hiding this comment.
the syslog hostname comes from cfg.Hostname rather than the simulated identity, so it doesn't match host.name.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Multi-product F5 log generator spanning the BIG-IP modules, NGINX-on-F5, iRules, and F5OS. F5 logging is largely operator-defined, so fidelity splits two ways:
Checklist