Declare fields in PatchscopeBase - #27
Closed
tvhong wants to merge 1 commit into
Closed
Conversation
PatchscopeBase references the fields inside the child class Patchscope. This breaks Intellisense. So, I'm declaring all fields inside PatchscopeBase. To do this properly, I either need to move SourceContex & TargetContext to patchscope_base.py, or move PatchscopeBase to patchscope.py. I picked the later.
Collaborator
Author
|
Closing this PR, please review #35 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PatchscopeBase references the fields inside the child class Patchscope.
This breaks Intellisense. So, I'm declaring all fields inside PatchscopeBase. To do this properly, I either need to move SourceContex & TargetContext to patchscope_base.py, or move PatchscopeBase to patchscope.py. I picked the later.