Skip to content

Conversation

@yewentai
Copy link

Following the refactoring of LMS (Learning Management System) and
Skills, the module retained duplicate reporting capabilities regarding
certifications.

This commit removes the dedicated "Employee Certification Report"
(including its model, views, menu items, and access rights) as it is
redundant and no longer accessible from the user interface.

Additionally, this commit:

  • Removes the intermediate "Skills" menu container, moving the "Skills
    Inventory" and "Learning" reports directly under "HR Reports".
  • Removes the default "Group By" context from the "Learning >
    Certifications" list view to provide a flat list by default.

arpi-odoo and others added 9 commits December 1, 2025 07:22
Make new contract button invisible when contract start date is not set

Task: 5376418
Following the refactoring of LMS and
Skills, the module retained duplicate reporting capabilities regarding
certifications.

This commit removes the dedicated "Employee Certification Report"
(including its model, views, menu items, and access rights) as it is
redundant and no longer accessible from the user interface.

Additionally, this commit:
- Removes the intermediate "Skills" menu container, moving the "Skills
  Inventory" and "Learning" reports directly under "HR Reports".
- Removes the default "Group By" context from the "Learning >
  Certifications" list view to provide a flat list by default.
Copilot AI review requested due to automatic review settings December 11, 2025 09:52
@yewentai yewentai self-assigned this Dec 11, 2025
@robodoo
Copy link

robodoo commented Dec 11, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-joyep, it needs to be retargeted before it can be merged.

@yewentai yewentai marked this pull request as draft December 11, 2025 09:52
@robodoo
Copy link

robodoo commented Dec 11, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-joyep, it needs to be retargeted before it can be merged.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes duplicate certification reporting functionality from the hr_skills module following the LMS and Skills refactoring. The dedicated "Employee Certification Report" is removed entirely as it is redundant and inaccessible from the UI.

  • Completely removes the hr.employee.certification.report model and all associated files
  • Restructures the menu hierarchy by eliminating the intermediate "Skills" menu container
  • Simplifies the certifications list view by removing the default "Group By" filter

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
addons/hr_skills/__manifest__.py Removes reference to deleted certification report views file from data list
addons/hr_skills/report/__init__.py Removes import of deleted certification report module
addons/hr_skills/report/hr_employee_certification_report.py Deletes the certification report model entirely (71 lines removed)
addons/hr_skills/report/hr_employee_certification_report_views.xml Deletes all certification report views including pivot, list, search, action, and menu (71 lines removed)
addons/hr_skills/security/ir.model.access.csv Removes access rights for the deleted certification report model
addons/hr_skills/report/hr_employee_skill_report_views.xml Updates Skills Inventory menu parent from intermediate "Skills" menu to "HR Reports"
addons/hr_skills/views/hr_views.xml Removes intermediate "Skills" menu container and default group-by context from certifications view

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@YassinWalid YassinWalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. I have two small comments though. The commit message is lacking the task number, and you should write an upgrade script to remove the deleted action, menus, and model from the databases when upgrading to the new version. You can find a guide here. (also you can check the upgrade-util symlink in the Newbies Onboarding knowledge page if it helps)

@arpi-odoo arpi-odoo force-pushed the master-hr-onboarding-joyep branch from 8eee53f to 325f8ab Compare December 15, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants