[REF] owl-core: model validation context as a class#1906
Open
ged-odoo wants to merge 1 commit into
Open
Conversation
Replace the per-descent closure-bag built by createContext with a single ValidationContext class threaded through the whole run: validateKey descends and restores in place (no child-context allocation, path snapshotted only when an issue is recorded) and runIsolated runs a validator against a throwaway issue list for unions. This drops the issueDepth/parent side-channel; a union now reports the branch that failed below its own level by comparing issue paths against its base path directly. In types.ts, a small validator() helper centralizes the phantom-type casts that were spread across every factory as 'as any'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the per-descent closure-bag built by createContext with a single ValidationContext class threaded through the whole run: validateKey descends and restores in place (no child-context allocation, path snapshotted only when an issue is recorded) and runIsolated runs a validator against a throwaway issue list for unions.
This drops the issueDepth/parent side-channel; a union now reports the branch that failed below its own level by comparing issue paths against its base path directly. In types.ts, a small validator() helper centralizes the phantom-type casts that were spread across every factory as 'as any'.