Master ref signal ged#1922
Merged
Merged
Conversation
mcm-odoo
reviewed
Jun 8, 2026
Refs are typically declared as `myRef = signal(null)` and bound with t-ref, but the signal is then inferred as Signal<null>. signal.ref() returns a null signal properly typed as Signal<HTMLElement | null>, or narrower when given a constructor: signal.ref(HTMLInputElement). The type option on signals is compile-time only, so the helper is just a null signal with better overloads (mirroring types.ref), with no runtime DOM reference. types.ref() called without a constructor built its validator with instanceType(undefined), so validating any non-null value threw "Right-hand side of 'instanceof' is not callable" instead of reporting a validation issue.
ged-odoo
force-pushed
the
master-ref-signal-ged
branch
from
f0a845f to
27b5b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.