Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

fix disable browser autocomplete - Closes #422 - #423

Open
nyvio wants to merge 1 commit into
oferh:masterfrom
nyvio:fixAutocomplete
Open

nyvio wants to merge 1 commit into
oferh:masterfrom
nyvio:fixAutocomplete

Conversation

@nyvio

@nyvio nyvio commented Mar 1, 2019

Copy link
Copy Markdown

Chrome doesn't take into account any more the html autocomplete="off" attribute.
As a result, the browser's autocomplete suggestions will overlap the suggestions we actually want to display with this component.

The only available workaround for now seems to be to give a value which is semantically significant for the given input, but which can't be interpreted by the browser as a known value for autocomplete.

See here, the reply from Chromium on this specific issue: https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164

In cases where you really want to disable autofill, our suggestion at this point is to utilize the autocomplete attribute to give valid, semantic meaning to your fields. If we encounter an autocomplete attribute that we don't recognize, we won't try and fill it.

It is a quick and effective workaround, which has a real impact for us.

Feel free to comment, I'm open to discussion and happy to contribute.

- Chrome doesn't take into account any more the autocomplete="off"
attribute. As a result, the browser's autocomplete suggestions will
overlap the suggestions we actually want to display with this component.
- The only available workaround for now seems to be to give a
value which is semantically significant for the given input, but which
can't be interpreted by the browser as a known value for autocomplete.
@nyvio nyvio changed the title change value of html autocomplete attribute fix disable browser autocomplete Mar 1, 2019
@nyvio nyvio changed the title fix disable browser autocomplete fix disable browser autocomplete - Closes #422 Mar 1, 2019

@cocode32 cocode32 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems to work 100% and fixes the issue 👍 :) thanks @nyvio

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants