Repository navigation
themes/duru: fix undefined ${gray} in venv prompt - #774
Merged
Merged
Conversation
${gray} is never defined by oh-my-bash (the color variables are
_omb_prompt_*, and plain 'gray' is not among the deprecated
compatibility names), so the " in " before the virtualenv name
rendered uncolored. Use ${_omb_prompt_gray}.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SABAE23V7T3PvYht4QmG9j
PR Summary by Qodothemes/duru: Fix undefined gray color in venv prompt
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can tweak Display preferences with a live preview to see your comment before it ships |
Contributor
|
Thank you for the report. I've checked the history, but it seems to have been broken since the beginning when the setting was introduced in e65c390. |
akinomyoga
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
venvfunction in the duru theme colors the" in "text with${gray}, butgrayis never defined: the color variables are all_omb_prompt_*(lib/omb-prompt-colors.sh), and plaingrayis not among the deprecated compatibility names either (black,cyan,white,orangeand thebold_*/underline_*/background_*variants are). The variable expands to empty, so the text renders in whatever color was active before instead of gray.Use
${_omb_prompt_gray}, matching the_omb_prompt_redalready used on the next segment.Noticed while porting duru to a custom theme.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SABAE23V7T3PvYht4QmG9j