Skip to content

fix(plugins/donottrack): disable opentelemetry sdk tracking - #775

Merged
akinomyoga merged 1 commit into
ohmybash:masterfrom
RobLoach:patch-1
Aug 30, 2026
Merged

akinomyoga merged 1 commit into
ohmybash:masterfrom
RobLoach:patch-1

Conversation

@RobLoach

Copy link
Copy Markdown
Contributor

The OpenTelemetry SDK has an environment variable we can add: https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/

OTEL_SDK_DISABLED

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Disable OpenTelemetry SDK telemetry in do-not-track plugin

🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Disables OpenTelemetry SDK telemetry when the do-not-track plugin loads.
• Preserves any user-defined OTEL_SDK_DISABLED value.
High-Level Assessment

Using the OpenTelemetry-standard OTEL_SDK_DISABLED environment variable through the existing helper is the optimal approach because it matches the plugin's established behavior and preserves explicit user configuration.

Files changed (1) +1 / -0

Bug fix (1) +1 / -0
donottrack.plugin.shDisable the OpenTelemetry SDK by default +1/-0

Disable the OpenTelemetry SDK by default

• Adds 'OTEL_SDK_DISABLED=true' to the data and machine-learning telemetry opt-outs. The existing helper exports this default without overriding a value already set by the user.

plugins/donottrack/donottrack.plugin.sh

@RobLoach RobLoach changed the title fix(plugin/donottrack): disable tracking for the opentelemetry sdk fix(plugins/donottrack): disable opentelemetry sdk tracking Aug 25, 2026
@akinomyoga
akinomyoga merged commit 0bd2d2c into ohmybash:master Aug 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants