plugin: add optional suffix to tds for multiple tmux sessions per directory

[senderic]

Summary

Allow tds to accept an optional suffix argument so users can create multiple tmux sessions for the same directory (e.g., tds codex, tds claude). The session name format becomes {dirname}-{hash}-{suffix} when a suffix is provided.

Also added tdss alias as a dedicated command for the same functionality.

Changes

• Modified plugins/tmux/tmux.plugin.bash: Updated _omb_plugin_tmux_directory_session function to accept optional suffix argument; added _omb_plugin_tmux_directory_session_suffix function and tdss alias
• Modified plugins/tmux/README.md: Updated documentation for tds and added tdss alias

Testing

Tested locally with oh-my-bash:

• tds creates session {dirname}-{hash}
• tds codex creates session {dirname}-{hash}-codex
• tds claude creates session {dirname}-{hash}-claude
• tdss codex works the same way

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Support suffixed tmux directory sessions and session completion

✨ Enhancement 📝 Documentation 🕐 10-20 Minutes

AI Description

• Allows optional suffixes for parallel per-directory tmux sessions.
• Adds tdss as a dedicated suffix-aware command.
• Completes session names for attach and kill aliases.

Diagram

graph TD
  CMD["tds / tdss"] --> BUILD["Directory functions"] --> HASH{"Hash tool?"}
  HASH -->|Available| NAME["Session name"] --> TMUX["tmux session"]
  HASH -->|Missing| ERROR["Command error"]
  ALIASES["ta tad tkss"] --> COMPLETE["Session completion"] --> TMUX

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Share one directory-session implementation

• ➕ Eliminates duplicated hashing and session-name construction logic.
• ➕ Prevents tds and tdss behavior from diverging.
• ➕ Retains both user-facing aliases with less maintenance overhead.
• ➖ Error messages cannot identify the invoked alias without passing additional context.
• ➖ Requires deciding whether tdss should remain distinct from tds semantically.

2. Separate session completion change

• ➕ Keeps the PR focused on suffixed directory sessions.
• ➕ Allows completion behavior and escaping to be reviewed and tested independently.
• ➖ Requires another PR and delays availability of the completion enhancement.

Recommendation: Use _omb_plugin_tmux_directory_session as the single suffix-aware implementation and point both tds and tdss to it. The completion addition is useful but orthogonal; it should either receive targeted tests here or move to a focused follow-up.

Files changed (2) +43 / -2

Enhancement (1) +41 / -1

tmux.plugin.bashAdd suffixed sessions, tdss, and alias completion +41/-1

Add suffixed sessions, tdss, and alias completion

• Extends 'tds' session names with an optional first-argument suffix and adds equivalent functionality through 'tdss'. It also registers session-name completion for 'ta', 'tad', and 'tkss'.

plugins/tmux/tmux.plugin.bash

Documentation (1) +2 / -1

README.mdDocument suffix-aware directory session aliases +2/-1

Document suffix-aware directory session aliases

• Documents optional suffix usage for 'tds' and adds the new 'tdss' command to the alias reference.

plugins/tmux/README.md

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Mac users attach to the wrong session ✓ Resolved 🐞 Bug ≡ Correctness

Description

_omb_plugin_tmux_directory_session_suffix invokes BSD md5 without -q, then truncates its
formatted output rather than the digest. When md5sum is unavailable, paths with the same basename
and suffix generate the same target, so a later tdss invocation attaches to the earlier
directory's session.

Code

plugins/tmux/tmux.plugin.bash[R58-59]

+  elif _omb_util_command_exists md5; then
+    md5=$(printf '%s' "$PWD" | md5)

Evidence

The new helper captures plain md5 output and slices it when constructing the session name.
Elsewhere, the repository explicitly uses md5 -q on Darwin while using md5sum | cut on other
systems, demonstrating that the quiet flag is required to obtain the raw BSD digest.

plugins/tmux/tmux.plugin.bash[53-67]
completions/gradle.completion.sh[9-15]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new `tdss` helper uses formatted BSD/macOS `md5` output, making its six-character hash prefix constant and allowing same-named directories to collide.
## Fix Focus Areas
- plugins/tmux/tmux.plugin.bash[53-67]
- plugins/tmux/tmux.plugin.bash[36-39]
## Recommended Fix
Invoke BSD/macOS `md5` with `-q` so only the digest is captured. Prefer making `tdss` delegate to the corrected directory-session helper rather than maintaining a second copy of the hashing logic.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. Escaped session names stop completing ✓ Resolved 🐞 Bug ≡ Correctness

Description

_omb_tmux_alias_sessions compares each unescaped session name against the escaped text retained in
COMP_WORDS, while applying %q only after that comparison. Once a user enters an escaped space or
metacharacter in a session-name prefix, the prefix test rejects the matching session for ta,
tad, and tkss.

Code

plugins/tmux/tmux.plugin.bash[R81-84]

+  for s in "${sessions[@]}"; do
+    [[ $s == "$cur"* ]] || continue
+    printf -v escaped '%q' "$s"  # escapes spaces/glob metachars
+    COMPREPLY+=("$escaped")

Evidence

The function reads cur directly from COMP_WORDS, splits tmux output into raw session strings,
tests the raw string against cur, and only afterward escapes the result. The registered completion
applies this mismatched comparison to all three aliases.

plugins/tmux/tmux.plugin.bash[73-88]
lib/utils.sh[450-457]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new tmux completion compares escaped command-line input with raw session names, preventing continued completion of names containing spaces or shell metacharacters.
## Fix Focus Areas
- plugins/tmux/tmux.plugin.bash[73-85]
## Recommended Fix
Normalize both values before prefix matching. One direct approach is to generate the `%q` form of each session before the test, compare that escaped value with `cur`, and append the same value to `COMPREPLY`; also cover names containing spaces and metacharacters with completion tests.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Tip of the day

💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗