fix(security): bind MinIO ports to 127.0.0.1 by default#13
Merged
Conversation
The default docker-compose published MinIO's S3 API (9000) and console
(9001) on 0.0.0.0 with the dev-default minioadmin/minioadmin
credentials, exposing the object store to anyone on the LAN. Bind both
ports to 127.0.0.1 by default via ${MINIO_BIND:-127.0.0.1}; users who
need LAN access can set MINIO_BIND=0.0.0.0 in .env. Documented the
override in .env.example and docs-site/docs/deployment/docker.md.
Closes #10
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127.0.0.1by default via${MINIO_BIND:-127.0.0.1}so the dev-defaultminioadmin/minioadmincredentials are not reachable from the LAN.MINIO_BIND=0.0.0.0override in.env.exampleanddocs-site/docs/deployment/docker.mdfor users who need LAN access.Closes #10
Test plan
docker compose --profile apple configshowshost_ip: 127.0.0.1on both 9000 and 9001 by default.MINIO_BIND=0.0.0.0 docker compose --profile apple configshowshost_ip: 0.0.0.0(override works).waldo-netbridge is unaffected (other services still hitminio:9000/mc alias set waldo http://minio:9000).testworkflow green.