feat(make): auto-detect profile (apple/cpu/nvidia) for make up#14
Merged
Conversation
Default `PROFILE` in the Makefile now distinguishes Linux+NVIDIA from Linux/CPU/WSL hosts: Darwin -> apple, Linux/WSL with nvidia-smi on $PATH -> nvidia, otherwise -> cpu. Previously every non-Darwin host silently fell back to apple, so `make up` on a Linux NVIDIA box ran CPU workers. Also drops the unused BACKEND variable, dispatches `up` directly off UNAME_S, adds the new `cpu` profile to docker-compose.yml (alongside the retained `apple` alias for one release), maps install.sh's WALDO_GPU=none to WALDO_PROFILE=cpu, and updates README.md + docs-site/docs/deployment/docker.md to document the three profiles and the auto-detect. Closes #11 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROFILEnow distinguishes Linux+NVIDIA from CPU/WSL hosts: Darwin ->apple, Linux/WSL withnvidia-smion$PATH->nvidia, otherwise ->cpu. Previously every non-Darwin host silently fell back toapple, somake upon a Linux NVIDIA box ran CPU workers.BACKENDvariable;updispatches directly offUNAME_Stoup-mac(Darwin) orup-linux(everywhere else).cpuprofile todocker-compose.ymlonwaldo-labeler/waldo-trainerwhile retaining the existingappleprofile as an alias for one release somake up PROFILE=applekeeps working.install.shsoWALDO_GPU=nonemaps toWALDO_PROFILE=cpu(wasapple);appleis now reserved for actual Apple Silicon.README.mdanddocs-site/docs/deployment/docker.md.Closes #11
Test plan
docker compose --profile cpu configvalidates and includeswaldo-labeler/waldo-trainer.docker compose --profile apple configvalidates and includes the same two services (alias).docker compose --profile nvidia configvalidates and includeswaldo-labeler-nvidia/waldo-trainer-nvidiaonly.make -n upin a container withoutnvidia-smiresolves to--profile cpu.make -n up PROFILE=nvidiaandPROFILE=appleoverrides still produce the expected--profile <X>invocations.Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com