[olemarkus]

Lands after the Dutch stack (#2969, #2970, #2971, #2980, #2981): don't merge before it.

Why

A car link that fails is recorded in the device journal, but the developer only hears of it from the next daily report or when the owner presses Send. The owner wants a report as soon as PELS sees something go wrong, starting with a charger that could not identify the connected car, and more events to follow.

What changes

• New switch: Settings → Advanced → Diagnostics reports gets Send a report on specific events (event_diagnostics_reports, off by default), below the daily report. Homey files every report as submitted by the user, so as with the daily report, only this switch sends one.
• First event: ev_car_link_unmatched. A charger whose window closed with no car identified gets a report about the charger, from an hour before its plug-in.
• lib/diagnostics/eventReportSchedule.ts:
  • Checks every 5 minutes, starting 17 minutes after start (two minutes off the daily report's hourly check), over the device events kept in the last 30 minutes. A report therefore also carries what followed its event.
  • REPORTED_EVENTS maps an event to the report it asks for. A new event is one entry there.
• Limits:
  • One report per event and device a day, and at most 6 attempts a day in all.
  • What was sent is written to the userdata database before sending, so a restart or a charger that keeps failing never sends twice.
  • A busy, unprepared or unsendable report is tried again on a later check. An uncertain one never is.
  • The switch is read again once the report is prepared.
• SupportReportService.sendOnEvent shares the daily report's unattended path and carries trigger: 'event'. Like the daily report, it trims its oldest activity to fit.
• Settings UI: both switches are driven from one list (diagnosticsReportSwitches.ts, which replaces dailyReportSwitch.ts).

Notes: notes/support-reports.md, notes/settings-key-ownership.md, notes/ev-car-link/README.md.

Validation

• New specs:
  • The schedule: sends once with the expected request, respects the switch and the lookback, follows the retry rule for every refusal code, never resends an uncertain report, honours the daily cap and the re-read switch, and ignores other events.
  • The service's event path.
  • An SDK e2e where a real charger fails to identify a car and exactly one report reaches Homey's endpoint, with none for a second failure the same day.
  • A browser spec for both switches. The section was also checked in a phone-width screenshot.
• Existing specs: the report and car-link specs and both SDK e2e files pass.
• Static checks: typecheck (all configs), eslint, arch:check, setup:boundaries, params:no-bundles, logging:no-legacy and lint:html are clean. The commit and pre-push hooks passed.
• Adversarial review: no blocker. Its should-fix (a 5-minute interval ran before the 15-minute first check) is fixed, along with its nits.

🤖 Generated with Claude Code

https://claude.ai/code/session_018xVzijrbDYE7H1nTowpvbh

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: olemarkus/com.barelysufficient.pels
• Branch: feat/event-diagnostics-reports
• File: .coderabbit.yaml
• Commit: 7fff9d1
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 06cd3865-1286-43b0-a161-9617370cacd8

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.