Conversation
Signed-off-by: Sven Wagner-Boysen <3901085+svenwb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #7862
Summary
This is a quality-of-life improvement for developers who have Corepack installed but have not enabled the pnpm shim. pnpm is already a documented prerequisite; omnidev now accepts
corepack pnpmas well, matchingsetup.py.Resolve the install and Vite commands before startup, reuse them for restarts, and report setup instructions when neither tool is available. Skip readiness polling when Vite cannot spawn. Custom process profiles and
--no-vitekeep their existing behavior.Other workflows that invoke pnpm directly retain that prerequisite. Broader developer-toolchain setup is outside this change.
Test Plan
cd dev/omnidev && cargo fmt --check && cargo test --offline --locked: all 73 tests passed.pre-commit run: passed on all five staged contribution files.PATH, ranCOREPACK_ENABLE_NETWORK=0 cargo runwith the pinned pnpm already cached. Vite became ready; the UI and proxied/healthreturned HTTP 200. Pressed3, thenrto restart Vite and verified both responses again.cargo runfromdev/omnidevin a configured checkout with Corepack but no pnpm shim. Confirm the Corepack fallback log, open the displayed UI URL, then press3,rand verify the UI still loads. Quit withq.Demo
N/A for visual media; this changes development-tool startup. Reproducible evidence is in Test Plan.
Type of change
Test coverage
Coverage notes
Tests exercise install/Vite arguments through a fake Corepack executable, standalone pnpm preference, missing or non-executable tools, and custom profile preservation. The binary-level regression test verifies missing tools produce actionable instructions before entering the TUI or starting servers. Startup and Vite restart were also verified manually on Linux; macOS was not tested.
Strict Clippy reports existing warnings in unchanged code:
unnecessary_map_orinpod.rsandsearch_is_someinomnigent_cmd.rs.Changelog
omnidev can use pnpm through Corepack without enabling its shim and gives setup instructions when neither tool is available.