Fix closing driver library in context destructor #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loop over zeDrivers (instead of allDrivers) vector in order to free driver libraries. Using allDrivers may not always work since if there's more than one driver discovered, drivers in allDrivers vector have null handles.
Contributor
|
allDrivers includes zeDrivers and zesDrivers, have to free both sets of drivers which are enumerated in allDrivers only. We also have a null check before the handle is attempted to be removed. Do you have example where you have encountered a failure? |
Contributor
|
Please see the following PR #416 this will address this issue without breaking other scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop over zeDrivers (instead of allDrivers) vector in order to free driver libraries. Using allDrivers may not always work since if there's more than one driver discovered, drivers in allDrivers vector have null handles.