chore: 馃嵄 add DK-EN mapping for choice values from REDCap - #176
Open
K-Beicher wants to merge 5 commits into
Open
chore: 馃嵄 add DK-EN mapping for choice values from REDCap#176K-Beicher wants to merge 5 commits into
K-Beicher wants to merge 5 commits into
Conversation
Contributor
Author
|
Got an error on just run-all, need to investigate that before I turn this into a PR. |
lwjohnst86
requested changes
Jul 29, 2026
lwjohnst86
left a comment
Member
There was a problem hiding this comment.
This should go under src/feasibility_data/metadata/redcap/. And also, file names need to always be lowercase
lwjohnst86
requested changes
Jul 29, 2026
lwjohnst86
left a comment
Member
There was a problem hiding this comment.
The redcap in the name is redundant since it's in the redcap folder, so you can remove that from the name. And you could rename the last bit to dk-to-en since en is the abbreviation for English.
lwjohnst86
requested changes
Jul 30, 2026
lwjohnst86
left a comment
Member
There was a problem hiding this comment.
You moved it into metadata/redcap/, but I said src/feasibility_data/metadata/redcap/ (in the src/ folder).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just storing the translations of the selectable values in redcap until we need them for the data analysis extracts.
Closes #74
Needs a quick review.
Checklist
just run-all