XLoader Relative URIs & Language Domain Plugin Support#229
Open
JVickery-TBS wants to merge 10 commits into
Open
XLoader Relative URIs & Language Domain Plugin Support#229JVickery-TBS wants to merge 10 commits into
JVickery-TBS wants to merge 10 commits into
Conversation
- Do not store absolute URIs in the database.
- Added change log file.
JVickery-TBS
changed the title
- Added support for the language_domains plugin.
wardi
reviewed
Jun 14, 2026
wardi
reviewed
Jun 14, 2026
Member
|
This feels like it would be better as a real language domains plugin interface or something. We can park that until later though. |
Author
|
Yeah my vanity domain plugin (https://github.com/open-data/ckanext-language-domains) is relying on monkey-patching and this specific core fix to not store resource urls in SOLR. ...and it kinda has to go a bit crazy with a Flask Middlware :/ So having some Interface in core to better control domains, root paths, and language directories could be useful. |
Author
|
@wardi sorry, gunna do the more specific domain_languages logic inside of that plugin in a chained package_show action. So this is truely just now to support relative XLoader URIs from the database and SOLR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(dev): xloader relative uris;
Similar to what we did for the resource URIs to not store absolute paths, and then just set the request domain in the package_show.
req: open-data/ckanext-xloader#36