Skip to content

Reusing 3x3 array #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcrrobinson wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reusing 3x3 array #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
103e99b
perf: reusing identity matrix for performance, removed redundency
mcrrobinson Feb 17, 2026
6ce5cb8
Apply suggestion from @leif81
mcrrobinson Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions opendis/RangeCoordinates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ class GPS:

wgs84 = WGS84()

_IDENTITY_3X3 = identity(3)

def ecef2lla(self, ecef, tolerance=1e-9):
"""Convert Earth-centered, Earth-fixed coordinates to lat, lon, alt.
Input: ecef - (x, y, z) in (m, m, m)
Expand Down Expand Up @@ -516,20 +518,16 @@ def rotate_3x3(self, theta, normal_vec):
the rotation.
"""

n_v_t = normal_vec.transpose()
Copy link
Member

@leif81 leif81 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n_v_t appears to be unused, makes sense to remove it. Good find.


n_x = array([[ 0 , -normal_vec[2], normal_vec[1] ],
[normal_vec[2] , 0 , -normal_vec[0]],
[-normal_vec[1], normal_vec[0] , 0 ]
]
)


I = identity(3)

nnt = normal_vec * self.transpose(normal_vec)

return (1 - cos(theta)) * nnt + cos(theta) * I + sin(theta) * n_x
return (1 - cos(theta)) * nnt + cos(theta) * self._IDENTITY_3X3 + sin(theta) * n_x


def transpose(self, arr):
Expand Down