Repository navigation
Conversation
Contributor
Author
baentsch
reviewed
Sep 19, 2026
0rlych1kk4
force-pushed
the
docs/signature-generation-special-cases
branch
2 times, most recently
from
September 25, 2026 09:35
0ae5b11 to
51da16c
Compare
baentsch
approved these changes
Sep 25, 2026
baentsch
left a comment
baentsch
left a comment
Member
There was a problem hiding this comment.
LGTM. Worthwhile creating an issue regarding the Windows failures? Are they liboqs problems or liboqs-rust problems, i.e., where should these be tracked?
Contributor
Author
|
Thanks @baentsch . Based on the failures, I think this is better tracked in liboqs first. The Rust wrapper is using the normal OQS_SIG interface, and the failure appears specific to the SHA-2 SLH-DSA signing paths on the Windows MSVC runner, while the corresponding SHAKE variants pass. I can open a liboqs issue with the failing variants and CI details, and reference it from liboqs-rust if useful. |
Signed-off-by: 0rlych1kk4 <orlychikka@gmail.com>
Signed-off-by: 0rlych1kk4 <orlychikka@gmail.com>
Signed-off-by: 0rlych1kk4 <orlychikka@gmail.com>
0rlych1kk4
force-pushed
the
docs/signature-generation-special-cases
branch
from
September 26, 2026 12:34
2e5e29d to
84d84bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the two intentional signature-generation exclusions discussed in #313:
extmuvariants are not exposed because they use a separate external-mu API surface.This is documentation-only and does not change the Rust API.