Repository navigation
fix pylint failures breaking Static Analysis (fixes #27) - #30
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pylint failures breaking Static Analysis
Fixes #27
Cause
The failing step is
pylint src/unidesk/(exit 30); ruff passes. Pylint was added in 7ca8502, but ruff was failing at that point, so the Pylint step was skipped. #26 fixed ruff, so pylint ran in CI for the first time. #26 exposed the failures; it didn't introduce them.Changes
Config (
.pylintrc, new)extension-pkg-allow-list=PyQt6: PyQt6 is a compiled extension, so pylint reported every Qt import asE0611(32 false positives).too-few-public-methods: Qt subclasses inherit their API from the base class.Code
autostart.py: open files withencoding="utf-8".widgets.py: rename the locals that shadowedfooter()and used the disallowed namebar. Extract acard(spacing)helper for the card frame duplicated incredits_page.pyandlinks_page.py(spacing stays 2 and 6).main_window.py: split the 62-statement_build_maininto_build_hero,_build_nav_columnand_build_bottom_row. Rename the unused signal arg to_state.academic_config_page.py: extract_academic_comboto get under the statement limit.main.py: add the missing final newline.Packaging
setup.py: define thedevextra (ruff,pylint) thatbuild.ymlalready installs with-e ".[dev]". The warningdoes not provide the extra 'dev'is gone.build.ymlis unchanged.Verification
In a clean venv, using the same commands as
build.yml:ruff check src/unidesk/: exit 0pylint src/unidesk/: exit 0, 10.00/10 (was exit 30, 5.45/10)main