Skip to content

fix pylint failures breaking Static Analysis (fixes #27) - #30

Merged
TolisSth merged 1 commit into
open-source-uom:mainfrom
YatesMold:fix/pylint-ci
Oct 20, 2026
Merged

TolisSth merged 1 commit into
open-source-uom:mainfrom
YatesMold:fix/pylint-ci

Conversation

@YatesMold

Copy link
Copy Markdown
Contributor

Fix pylint failures breaking Static Analysis

Fixes #27

Cause

The failing step is pylint src/unidesk/ (exit 30); ruff passes. Pylint was added in 7ca8502, but ruff was failing at that point, so the Pylint step was skipped. #26 fixed ruff, so pylint ran in CI for the first time. #26 exposed the failures; it didn't introduce them.

Changes

Config (.pylintrc, new)

  • extension-pkg-allow-list=PyQt6: PyQt6 is a compiled extension, so pylint reported every Qt import as E0611 (32 false positives).
  • Disable too-few-public-methods: Qt subclasses inherit their API from the base class.

Code

  • Add the missing module, class and function docstrings.
  • autostart.py: open files with encoding="utf-8".
  • widgets.py: rename the locals that shadowed footer() and used the disallowed name bar. Extract a card(spacing) helper for the card frame duplicated in credits_page.py and links_page.py (spacing stays 2 and 6).
  • main_window.py: split the 62-statement _build_main into _build_hero, _build_nav_column and _build_bottom_row. Rename the unused signal arg to _state.
  • academic_config_page.py: extract _academic_combo to get under the statement limit.
  • main.py: add the missing final newline.

Packaging

  • setup.py: define the dev extra (ruff, pylint) that build.yml already installs with -e ".[dev]". The warning does not provide the extra 'dev' is gone.

build.yml is unchanged.

Verification

In a clean venv, using the same commands as build.yml:

  • ruff check src/unidesk/: exit 0
  • pylint src/unidesk/: exit 0, 10.00/10 (was exit 30, 5.45/10)
  • Offscreen smoke test (all nav buttons, Back, Configure): same result as before (8 nav buttons, 10 stacked pages)
  • Widget tree and keyboard focus order on all pages: identical to main

@YatesMold YatesMold self-assigned this Oct 18, 2026
@YatesMold
YatesMold requested a balanced review from Copilot October 18, 2026 17:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@YatesMold
YatesMold requested a review from TolisSth October 18, 2026 17:26
@TolisSth
TolisSth merged commit 3eee14d into open-source-uom:main Oct 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix pipeline

3 participants